Skip to content

Limit servers to IPv4 to make them work with WSL #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −4
Open

Limit servers to IPv4 to make them work with WSL #5912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95fd8cc
Limit servers to IPv4 to make them work with WSL
stickeegreg Aug 21, 2025
7d79972
Merge branch 'master' into fix/wsl-artifacts
stickeegreg Aug 22, 2025
9c56133
Merge branch 'master' into fix/wsl-artifacts
stickeegreg Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/artifactcache/handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ func StartHandler(dir, customExternalURL string, outboundIP string, port uint16,

h.gcCache()

listener, err := net.Listen("tcp", fmt.Sprintf(":%d", port)) // listen on all interfaces
listener, err := net.Listen("tcp4", fmt.Sprintf(":%d", port)) // listen on all interfaces
if err != nil {
return nil, err
}
Expand All @@ -106,6 +106,7 @@ func StartHandler(dir, customExternalURL string, outboundIP string, port uint16,
Handler: router,
}
go func() {
logger.Infof("Start artifactcache server on http://0.0.0.0:%d", port)
if err := server.Serve(listener); err != nil && errors.Is(err, net.ErrClosed) {
logger.Errorf("http serve: %v", err)
}
Expand Down
11 changes: 8 additions & 3 deletions pkg/artifacts/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"fmt"
"io"
"io/fs"
"net"
"net/http"
"os"
"path/filepath"
Expand Down Expand Up @@ -291,16 +292,20 @@ func Serve(ctx context.Context, artifactPath string, addr string, port string) c
downloads(router, artifactPath, fsys)
RoutesV4(router, artifactPath, fsys, fsys)

listener, err := net.Listen("tcp4", fmt.Sprintf("%s:%s", addr, port))
if err != nil {
logger.Fatal(err)
}

server := &http.Server{
Addr: fmt.Sprintf("%s:%s", addr, port),
ReadHeaderTimeout: 2 * time.Second,
Handler: router,
}

// run server
go func() {
logger.Infof("Start server on http://%s:%s", addr, port)
if err := server.ListenAndServe(); err != nil && err != http.ErrServerClosed {
logger.Infof("Start artifact server on http://%s:%s", addr, port)
if err := server.Serve(listener); err != nil && err != http.ErrServerClosed {
logger.Fatal(err)
}
}()
Expand Down