Skip to content

Rename "New and returning attendees" to "Attendance history" #11219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbudin merged 2 commits into from
Mar 9, 2026
Merged

Rename "New and returning attendees" to "Attendance history" #11219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da0f3a
Rename "New and returning attendees" to "Attendance history"
nbudin Mar 9, 2026
d554404
Fix report menu order to be alphabetical after rename
nbudin Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions app/javascript/Reports/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,26 +27,26 @@ function ReportsMenu() {
<div className="card-body">
<ul className="mb-0">
{data.convention.ticket_mode !== 'disabled' && (
<>
<li>
<Link to="/reports/attendance_by_payment_amount">
{t('admin.reports.menu.attendanceByPaymentAmount')}
</Link>
</li>
<li>
<Link to="/reports/event_provided_tickets">
{t('admin.reports.menu.eventProvidedTickets', {
ticketNamePlural: data.convention.ticketNamePlural,
})}
</Link>
</li>
</>
<li>
<Link to="/reports/attendance_by_payment_amount">
{t('admin.reports.menu.attendanceByPaymentAmount')}
</Link>
</li>
)}
<li>
<Link to="/reports/events_by_choice">{t('admin.reports.menu.eventsByChoice')}</Link>
<Link to="/reports/new_and_returning_attendees">{t('admin.reports.menu.newAndReturningAttendees')}</Link>
</li>
{data.convention.ticket_mode !== 'disabled' && (
<li>
<Link to="/reports/event_provided_tickets">
{t('admin.reports.menu.eventProvidedTickets', {
ticketNamePlural: data.convention.ticketNamePlural,
})}
</Link>
</li>
)}
<li>
<Link to="/reports/new_and_returning_attendees">{t('admin.reports.menu.newAndReturningAttendees')}</Link>
<Link to="/reports/events_by_choice">{t('admin.reports.menu.eventsByChoice')}</Link>
</li>
<li>
<Link to="/reports/signup_spy">{t('admin.reports.menu.signupSpy')}</Link>
Expand Down
4 changes: 2 additions & 2 deletions locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@
"attendanceByPaymentAmount": "Attendance by payment amount",
"eventProvidedTickets": "Event-provided {{ ticketNamePlural }}",
"eventsByChoice": "Events by choice",
"newAndReturningAttendees": "New and returning attendees",
"newAndReturningAttendees": "Attendance history",
"signupSpy": "Signup spy",
"eventsByTime": "Events by time",
"perEventReport": "Per event report",
Expand All @@ -227,7 +227,7 @@
"nameHeader": "Name",
"newAttendeesLabel": "New attendees",
"returningAttendeesLabel": "Returning attendees",
"title": "New and returning attendees",
"title": "Attendance history",
"totalLabel": "Total"
}
},
Expand Down
Loading