Skip to content

fix(ci): claude review workflow never triggered due to secrets in step if #16018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darioush merged 4 commits into from
Jul 8, 2026
Merged

fix(ci): claude review workflow never triggered due to secrets in step if #16018

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
66b1961
fix(ci): claude review workflow never triggered due to secrets in ste…
Jul 3, 2026
ab08778
fix(ci): pass github token to claude review action instead of requiri…
Jul 3, 2026
3979c85
Merge branch 'master' into peter-near/ci/fix-claude-review-trigger
peter-near Jul 3, 2026
484f0dc
Address Copilot comments
Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/claude-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ jobs:
id-token: write

steps:
# secrets are not allowed in step-level `if:` expressions, so record the
# key's presence as a step output for the review step's condition. Kept
# as a dedicated step before checkout so the secret is never exposed to
# steps that execute code from the checked-out ref.
- name: Check for API key
id: key-check
env:
ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
run: echo "present=${ANTHROPIC_API_KEY:+true}" >> "$GITHUB_OUTPUT"

- name: Checkout repository
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8
with:
Expand Down Expand Up @@ -78,11 +88,14 @@ jobs:

- name: Run Claude Code Review
id: claude-review
if: ${{ secrets.ANTHROPIC_API_KEY != '' }}
if: ${{ steps.key-check.outputs.present == 'true' }}
uses: anthropics/claude-code-action@2cc1ac1331eac7a6a96d716dd204dd2888d0fcd2 # main @ Claude Code 2.1.128 / Agent SDK 0.2.128 (needed for --effort xhigh)
env:
GH_TOKEN: ${{ github.token }}
Comment thread
peter-near marked this conversation as resolved.
with:
# without github_token the action tries to mint a token via the
# Claude Code GitHub App, which is not installed on this repo
github_token: ${{ github.token }}
anthropic_api_key: ${{ secrets.ANTHROPIC_API_KEY }}
prompt: ${{ env.REVIEW_PROMPT }}
claude_args: >-
Expand Down
Loading