chore(tee): move cluster deploy/test scripts to mpc-private - #3895
Conversation
Removes the TEE cluster deploy/test scripts (deploy-tee-cluster.sh, set-*-env.sh, create-and-sweep-to-treasury.sh, test-migration.sh, test-verify-and-upgrade.sh, test-hash-override.sh, how-to-run doc); they now live in near/mpc-private tools/tee-cluster and run against a local mpc checkout via MPC_REPO_ROOT. Keeps single-node.sh (+ readme), common.sh and the templates here (the moved scripts reference them via MPC_REPO_ROOT; single-node.sh generates the Rust test fixtures). Repoints the testnet setup guide and trims the rust-launcher README accordingly. Replaces #3888.
636845d to
53d98f8
Compare
There was a problem hiding this comment.
Pull request overview
Moves the TEE cluster deploy/test operational scripts out of the public repo and into the internal near/mpc-private tooling location, while keeping the shared helpers/templates and the single-node test-asset generation script in mpc. This reduces churn and review load in this repo while preserving the in-repo pieces that the private tooling references via MPC_REPO_ROOT.
Changes:
- Remove the cluster deploy/test scripts and their how-to doc from
localnet/tee/scripts/rust-launcher/(they are intended to live innear/mpc-private/tools/tee-cluster/). - Update
localnet/tee/scripts/rust-launcher/README.mdto reflect the split (cluster tooling moved; shared bits + single-node remain). - Repoint the testnet setup guide’s N-node section to the internal tooling.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| localnet/tee/scripts/rust-launcher/test-verify-and-upgrade.sh | Removed (cluster verification/upgrade test script moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/test-migration.sh | Removed (cluster migration test script moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/test-hash-override.sh | Removed (hash override test script moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/set-testnet-env.sh | Removed (testnet env preset moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/set-localnet-env.sh | Removed (localnet env preset moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/README.md | Updated to point cluster scripts to near/mpc-private and document what remains here. |
| localnet/tee/scripts/rust-launcher/how-to-run-deploy-tee-cluster.md | Removed (cluster deploy how-to moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/deploy-tee-cluster.sh | Removed (cluster deploy script moved to internal tooling). |
| localnet/tee/scripts/rust-launcher/create-and-sweep-to-treasury.sh | Removed (testnet funding helper moved to internal tooling). |
| docs/testnet/setup-guide-for-testnet-with-tee-support.md | Updated to direct N-node deployments/scaling to internal tooling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Pull request overviewRemoves the TEE cluster deploy/test shell scripts ( Changes:
Reviewed changesPer-file summary
FindingsVerified: no in-repo file (scripts, Rust, docs, CI configs) still references the deleted scripts as if they were local. Non-blocking (nits, follow-ups, suggestions):
✅ Approved |
Drop the dangling deploy-tee-cluster.sh reference (moved to mpc-private) and the outdated 'older test scripts disagreed on bob' aside; keep the canonical/shared IP-layout note.
|
Thanks — both fair.
Fixed in 77ded7d. Dropped the dangling
Correct, and this is the one that matters: #3895 must merge after near/mpc-private#495 (still open), or the testnet setup guide points at tooling that isn't there yet. It's ready for review, but should be held from merge until #495 lands. |
| For deploying **N nodes at once** (or scaling up existing networks), the | ||
| automated deploy tooling (`deploy-tee-cluster.sh` — resumable and phase-based: | ||
| account creation, contract deployment, key generation, attestation, and voting) | ||
| lives in the internal `near/mpc-private` repo under `tools/tee-cluster/`. It runs | ||
| against a local mpc checkout via `MPC_REPO_ROOT`; see that directory's `README.md` | ||
| and `how-to-run-deploy-tee-cluster.md` for the full reference. |
There was a problem hiding this comment.
Nit: This might be confusing for external readers - should we move this doc to our internal repo as well?
There was a problem hiding this comment.
docs/testnet/setup-guide-for-testnet-with-tee-support.md is similar in nature to docs/localnet/localnet.md or docs/localnet/tee-localnet.md - So I think we should keep it in place.
Hopefully it won't confuse external reviewers too much, since it explains that automated script live in an internal mpc-private repo.
Closes #3894. Replaces #3888.
Removes the TEE cluster deploy/test scripts from
localnet/tee/scripts/rust-launcher/— they move to the internalnear/mpc-privaterepo (tools/tee-cluster/, near/mpc-private#495) where they can change with lighter review:deploy-tee-cluster.sh,set-localnet-env.sh,set-testnet-env.sh,create-and-sweep-to-treasury.sh,test-migration.sh,test-verify-and-upgrade.sh,test-hash-override.sh,how-to-run-deploy-tee-cluster.mdKept here (the moved scripts reference these via
MPC_REPO_ROOT):single-node.sh(+readme) — generates the Rust test fixtures, so it belongs with the codecommon.shand thenode.*.tpltemplatesAlso repoints the testnet setup guide's N-node section to the internal tooling and trims the rust-launcher README.
Draft until near/mpc-private#495 lands — so the tooling exists in mpc-private before it's removed here.