refactor: importing reconstruction threshold from crypto into node#3596
Draft
SimonRastikian wants to merge 15 commits into
Draft
refactor: importing reconstruction threshold from crypto into node#3596SimonRastikian wants to merge 15 commits into
SimonRastikian wants to merge 15 commits into
Conversation
…-reconstruction-threshold
…-reconstruction-threshold
…-reconstruction-threshold
…dant double-construction at the node boundary
SimonRastikian
changed the title
SimonRastikian
changed the title
|
PR title type suggestion: This PR reorganizes code by importing threshold reconstruction logic into the node. The type prefix should be Suggested title: |
SimonRastikian
changed the base branch from
main
to
simon/renaming-reconstruction-lower-bound-to-reconstruction-threshold
…tion-threshold' into simon/importing-reconstruction-threshold-from-crypto-into-node
Base automatically changed from
simon/renaming-reconstruction-lower-bound-to-reconstruction-threshold
to
main
June 16, 2026 19:17
anodar
approved these changes
Jun 17, 2026
anodar
left a comment
anodar
left a comment
Collaborator
There was a problem hiding this comment.
is mpc_primitives::ReconstructionThreshold still used somewhere else ? If not should we drop it ?
Collaborator
|
Reading the thread offline, looks like there's been discussions and it's deliberate why there's duplicate structs. I'm probably not a best person to review this as I'm missing quite a bit of context on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3597