feat(tee-verifier): stateless `dcap_qvl::verify` wrapper contract by pbeza · Pull Request #3237 · near/mpc

pbeza · 2026-05-14T14:39:15Z

Overview

Adds tee-verifier: a stateless TEE attestation verifier contract.

It wraps dcap_qvl::verify::verify in a single verify_quote method. The contract holds no state and has no admin — verifier-internal policy (the dcap-qvl version, Intel root certs, etc.) is bound to the deployed code hash. Per-team allowlists, report-data binding, and other post-DCAP checks live in the caller, not here.

This moves the heavy dcap-qvl / ring / webpki / x509-cert closure out of any contract that needs quote verification and into this one contract, reached over a cross-contract call using the DTOs from #3235.

Builds on #3235 (PR #3235); part of the stack tracked by #3264. See docs/design/attestation-verifier-contract.md for the design.

…-qvl Pure crate split, no behaviour change. Sets up the WASM-size win that the follow-up PR (mpc-contract Promise refactor) will land. What moves: - `app_compose`, `measurements`, `report_data`, `tcb_info` modules and their assets — none of these touched `dcap-qvl` to begin with. - The post-DCAP verification helpers (`verify_tcb_status`, `verify_report_data`, `verify_rtmr3`, `verify_app_compose`, `verify_any_measurements`, `verify_static_rtmrs`, `verify_key_provider_digest`, `verify_event_log_rtmr3`, `validate_app_compose_config`, `compare_hashes`, `compare_hex_hashes`, plus the `OrErr` and `GetSingleEvent` traits and `VerificationError`) — refactored from private methods on `DstackAttestation` to free functions in `attestation_types::verify_post_dcap`, taking the `tee_verifier_interface::VerifiedReport` mirror instead of the `dcap_qvl` type. What stays in `attestation`: - `DstackAttestation::verify` (the one and only `dcap_qvl::verify::verify` call site). It now converts the dcap-qvl-returned report to the Borsh mirror once and calls the free functions on it. - The `Collateral` newtype and `QuoteBytes` newtype. Their dedup with the `tee-verifier-interface` mirrors is deferred to a later PR. What this enables (next PR): - `mpc-contract` can depend on `attestation-types` alone (no `dcap-qvl`) and call the post-DCAP helpers from a Promise callback that receives the verifier-returned `VerifiedReport`. That is the actual WASM-size win for NEP-509. Drops the dead `TryFrom<dcap_qvl::verify::VerifiedReport> for Measurements` impl (no callers anywhere in the codebase). Re-exports the moved modules from `attestation::lib.rs` so existing consumers (`mpc-attestation`, `tee-authority`, `attestation-cli`, etc.) keep their import paths unchanged. Part of the verifier breakout from docs/design/attestation-verifier-contract.md (#3160). Stacked on #3237.

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

…n tests Matches the repo convention (and `conversions.rs` in this crate), so the attribute warns if the lint stops being triggered.

- Bump the NEP-330 reproducible-build image to 0.21.1-rust-1.93.0 to match `rust-toolchain.toml` and `crates/contract` (was 0.17.0-rust-1.86.0). - Convert the fixture timestamp with `u64::try_from(...).expect(...)` instead of a silently-truncating `as u64` cast. - Use `err.to_string()` instead of `format!("{err}")`.

barakeinav1

LGTM, aligned to the changes we agreed upon in #3235. verify_quote returning VerificationResult resolves the failure-distinguishability concern, conversions are field-for-field correct and pinned against dcap-qvl, and the negative-path tests are a good add. 👍

One nit inline.

The crate uses `borsh::` directly in the `conversions.rs` layout-pinning tests, so cargo-shear sees `borsh` as used — unlike the contract template this was copied from, which doesn't touch borsh. The ignore was redundant.

…tract

gilcu3

Thank you!

gilcu3 · 2026-06-10T09:20:13Z

+fn make_collateral() -> Collateral {
+    // `test_utils::attestation::collateral()` returns a `serde_json::Value`
+    // matching `attestation::Collateral`'s JSON shape. We re-parse it
+    // into the interface crate's mirror type by extracting the same
+    // field names that `dcap_qvl::QuoteCollateralV3` uses.
+    let v = collateral_json();
+    Collateral {
+        pck_crl_issuer_chain: v["pck_crl_issuer_chain"].as_str().unwrap().to_string(),
+        root_ca_crl: hex::decode(v["root_ca_crl"].as_str().unwrap()).unwrap(),
+        pck_crl: hex::decode(v["pck_crl"].as_str().unwrap()).unwrap(),
+        tcb_info_issuer_chain: v["tcb_info_issuer_chain"].as_str().unwrap().to_string(),
+        tcb_info: v["tcb_info"].as_str().unwrap().to_string(),
+        tcb_info_signature: hex::decode(v["tcb_info_signature"].as_str().unwrap()).unwrap(),
+        qe_identity_issuer_chain: v["qe_identity_issuer_chain"].as_str().unwrap().to_string(),
+        qe_identity: v["qe_identity"].as_str().unwrap().to_string(),
+        qe_identity_signature: hex::decode(v["qe_identity_signature"].as_str().unwrap()).unwrap(),
+        pck_certificate_chain: v
+            .get("pck_certificate_chain")
+            .and_then(|s| s.as_str())
+            .map(str::to_string),
+    }
+}


I am surprised we need such manual conversion here. I would expect we should have that conversion code somewhere already

Yeah, looks like there are no existing conversions for this, but we can easily add one (see demo: #3521).

The issue is that we don’t want to add a dependency on MPC-specific crates to tee-verifier, since it’s supposed to stay MPC-agnostic and potentially be used by external teams too.

yeah, maybe in a future refactor this will become easier, thank you for giving it a try

gilcu3

ups found a small blocker

…-contract Align the verifier contract's reproducible-build command with mpc-contract; it was missing the release-contract profile.

pbeza force-pushed the feat/tee-verifier-interface branch from b3acde8 to 820497e Compare May 15, 2026 09:18

pbeza force-pushed the feat/tee-verifier-contract branch from eb25314 to 7766451 Compare May 15, 2026 09:29

pbeza mentioned this pull request May 15, 2026

feat(tee-verifier-interface): Borsh DTOs for the verifier contract boundary #3235

Merged

pbeza force-pushed the feat/tee-verifier-interface branch from 820497e to 2e70aa9 Compare May 15, 2026 10:20

pbeza force-pushed the feat/tee-verifier-contract branch from 7766451 to 43413b5 Compare May 15, 2026 10:23

pbeza mentioned this pull request May 15, 2026

refactor(attestation): extract attestation-types crate without dcap-qvl #3245

Closed

This was referenced May 18, 2026

Move dcap-qvl out of the mpc-contract WASM #3264

Closed

Introduce tee-verifier contract (stateless dcap_qvl::verify wrapper) #3266

Closed

Switch mpc-contract to Promise + callback verification #3269

Closed

pbeza force-pushed the feat/tee-verifier-interface branch from 2e70aa9 to dde7dd2 Compare June 3, 2026 09:08

pbeza force-pushed the feat/tee-verifier-contract branch from 43413b5 to 5fae5d5 Compare June 3, 2026 09:08

pbeza changed the title ~~feat(tee-verifier): stateless dcap_qvl::verify wrapper contract~~ feat(tee-verifier): stateless dcap_qvl::verify wrapper contract Jun 3, 2026

pbeza force-pushed the feat/tee-verifier-contract branch from d1e513b to 54fc11c Compare June 3, 2026 10:37

pbeza force-pushed the feat/tee-verifier-interface branch from b731b70 to c3f7c04 Compare June 3, 2026 10:42

pbeza force-pushed the feat/tee-verifier-contract branch 3 times, most recently from 56f6430 to d69203b Compare June 3, 2026 12:05

pbeza force-pushed the feat/tee-verifier-interface branch from a288dbd to b2ff62d Compare June 3, 2026 12:05

pbeza force-pushed the feat/tee-verifier-contract branch 2 times, most recently from 5edeb86 to 7f576f3 Compare June 3, 2026 13:01

pbeza force-pushed the feat/tee-verifier-interface branch 2 times, most recently from 198b297 to 77b14bb Compare June 3, 2026 14:35

pbeza force-pushed the feat/tee-verifier-contract branch from 7f576f3 to 6d043fe Compare June 3, 2026 14:35

pbeza marked this pull request as ready for review June 3, 2026 14:36

Copilot AI review requested due to automatic review settings June 3, 2026 14:36

Copilot started reviewing on behalf of pbeza June 3, 2026 14:36 View session

This comment was marked as outdated.

Sign in to view

pbeza force-pushed the feat/tee-verifier-contract branch from 6d043fe to cf72a5a Compare June 3, 2026 17:03

pbeza requested a review from gilcu3 June 3, 2026 17:15

pbeza requested a review from Copilot June 9, 2026 17:57

Copilot started reviewing on behalf of pbeza June 9, 2026 17:58 View session

near deleted a comment from claude Bot Jun 9, 2026

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread crates/tee-verifier/Cargo.toml

Comment thread crates/tee-verifier/tests/verify_quote.rs Outdated

Comment thread crates/tee-verifier/src/lib.rs

pbeza added 2 commits June 9, 2026 20:04

style(tee-verifier): use #[expect] over #[allow] for non_snake_case i…

06cf823

…n tests Matches the repo convention (and `conversions.rs` in this crate), so the attribute warns if the lint stops being triggered.

pbeza requested a review from barakeinav1 June 9, 2026 18:22

barakeinav1 previously approved these changes Jun 10, 2026

View reviewed changes

Comment thread crates/tee-verifier/Cargo.toml Outdated

chore(tee-verifier): drop redundant cargo-shear borsh ignore

38774c5

The crate uses `borsh::` directly in the `conversions.rs` layout-pinning tests, so cargo-shear sees `borsh` as used — unlike the contract template this was copied from, which doesn't touch borsh. The ignore was redundant.

pbeza dismissed barakeinav1’s stale review via 38774c5 June 10, 2026 08:52

Merge remote-tracking branch 'origin/main' into feat/tee-verifier-con…

2bbf1e1

…tract

pbeza requested a review from barakeinav1 June 10, 2026 08:53

barakeinav1 previously approved these changes Jun 10, 2026

View reviewed changes

gilcu3 approved these changes Jun 10, 2026

View reviewed changes

gilcu3 requested changes Jun 10, 2026

View reviewed changes

Comment thread crates/tee-verifier/Cargo.toml

pbeza mentioned this pull request Jun 10, 2026

demo(tee-verifier): reuse mpc-attestation collateral parsing in the verify_quote test #3521

Closed

fix(tee-verifier): build the reproducible WASM with --profile=release…

6082844

…-contract Align the verifier contract's reproducible-build command with mpc-contract; it was missing the release-contract profile.

pbeza dismissed barakeinav1’s stale review via 6082844 June 10, 2026 10:38

pbeza requested review from barakeinav1 and gilcu3 June 10, 2026 10:39

gilcu3 approved these changes Jun 10, 2026

View reviewed changes

pbeza enabled auto-merge June 10, 2026 10:54

barakeinav1 approved these changes Jun 10, 2026

View reviewed changes

pbeza added this pull request to the merge queue Jun 10, 2026

Merged via the queue into main with commit c371628 Jun 10, 2026
15 checks passed

pbeza deleted the feat/tee-verifier-contract branch June 10, 2026 11:03

pbeza mentioned this pull request Jun 11, 2026

feat: integrate the TEE attestation verifier contract into mpc-contract #3540

Closed

Navigation Menu

Uh oh!

feat(tee-verifier): stateless `dcap_qvl::verify` wrapper contract - #3237

feat(tee-verifier): stateless `dcap_qvl::verify` wrapper contract#3237
pbeza merged 11 commits into
mainfrom
feat/tee-verifier-contract

pbeza commented May 14, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barakeinav1 left a comment

Uh oh!

Uh oh!

gilcu3 left a comment

Uh oh!

gilcu3 Jun 10, 2026

Uh oh!

pbeza Jun 10, 2026

Uh oh!

gilcu3 Jun 10, 2026

Uh oh!

gilcu3 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

pbeza commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

barakeinav1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gilcu3 left a comment

Choose a reason for hiding this comment

Uh oh!

gilcu3 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

pbeza Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gilcu3 Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gilcu3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pbeza commented May 14, 2026 •

edited

Loading