Open
Conversation
|
Thank you! The fix looks correct and I'll incorporate it. While checking out the python code I realized this should have failed on mmap.close(). Which made me look again and I realized I'm also not closing the mmap (I'm simply destroying it). The practical effect is probably zero, but it will open up the possibility of a nice and short regression test, instead of running the fullblown fd counter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File descriptor leak during using of mmap for CDB creation has been observed.
Leak does not occur if
CDB.make(fd, mmap=False)is used. Ifmmapis set to eitherTrueorNonethen CDB does not close the file.Leak can be reproduced using script in
tools/fd_leak.py.Root cause
Function
cdb32_mmap()usesmmapthroughPyObject_Call(). ReturnedPy_Objectis passed toPyObject_GetBuffer(). Object is stored in viewPy_Bufferbut never released.