Open
Conversation
We now store screenshots in the storage directory on Windows, this is consistent with SDL
BrentDaMage
requested changes
Mar 28, 2026
BrentDaMage
requested changes
Mar 28, 2026
| createFolderIfNotExists(screenshot_path.c_str()); | ||
|
|
||
| screenshot_path += fileName; | ||
| screenshot_path += '\\' + fileName; |
Member
There was a problem hiding this comment.
Honestly, I could be wrong here, but I don't think this works. As far as I know, in order to concatenate a c-string and an std::string, you need to use an operator overload or directly call a function. In this case, there is no operator overload for + on a char*, so I can't imagine how this would work. Feel free to correct me though. I imagine you could solve this by appending the backslash on the line above.
| else | ||
| storagePath = "."; | ||
| } else | ||
| storagePath = appdata; |
Member
There was a problem hiding this comment.
wrap this in curly braces like the rest of the if statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will test NT 3 later