Skip to content

Better handle lack of assets directory + native message function#419

Closed
Un1q32 wants to merge 12 commits intonbcraft-org:masterfrom
Un1q32:native-message
Closed

Better handle lack of assets directory + native message function#419
Un1q32 wants to merge 12 commits intonbcraft-org:masterfrom
Un1q32:native-message

Conversation

@Un1q32
Copy link
Contributor

@Un1q32 Un1q32 commented Feb 8, 2026

reopening this cuz i made it its own branch

return result;
}

// this segfaults on wsl, why?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how the hell is SDL supposed to show a dialog box in WSL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using GTK or QT or something idk. It shouldn't crash it should at least return some kind of fail state so we can fallback to stderr.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

@Un1q32 Un1q32 closed this Mar 23, 2026
@Un1q32 Un1q32 deleted the native-message branch March 23, 2026 00:47
@BrentDaMage
Copy link
Member

Is there a reason the branch was deleted? I feel like someone could've worked off of this.

@Un1q32
Copy link
Contributor Author

Un1q32 commented Mar 23, 2026

The diff is still archived by GitHub. I might restart it with a much smaller scope, only implementing the message box for windows and letting everyone else use printf to stderr. I never finished it cuz I couldn't figure out how to make every platform behave consistently, some platforms block the thread until the box is dismissed, some don't, some have titles, some don't. It was very messy, it would be a lot easier and simpler to just only handle the text body and set a filler title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants