-
Notifications
You must be signed in to change notification settings - Fork 5
TFP-6071 nytt endepunkt og bruk av familiehendelse #6610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6fa1ab2
to
45d2ff6
Compare
45d2ff6
to
98f2936
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan du se over propnavn der typen er endret. Jeg tenker spesielt på tilfeller av
gjeldendeFamiliehendelse: AdopsjonFamilieHendelse
familiehendelse: AdopsjonFamilieHendelse
apps/fp-frontend-app/src/behandling/fellesPaneler/fakta/AdopsjonsvilkaretFaktaInitPanel.tsx
Outdated
Show resolved
Hide resolved
packages/fakta/omsorg-og-foreldreansvar/src/OmsorgOgForeldreansvarFaktaIndex.spec.tsx
Outdated
Show resolved
Hide resolved
packages/fakta/omsorg-og-foreldreansvar/src/OmsorgOgForeldreansvarFaktaIndex.spec.tsx
Show resolved
Hide resolved
packages/fakta/omsorg-og-foreldreansvar/src/OmsorgOgForeldreansvarFaktaIndex.tsx
Outdated
Show resolved
Hide resolved
packages/fakta/omsorg-og-foreldreansvar/src/components/OmsorgsovertakelseFaktaPanel.tsx
Outdated
Show resolved
Hide resolved
98f2936
to
63f116f
Compare
7bdf85c
to
bddbf5f
Compare
bddbf5f
to
96d51d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new API endpoint for family events and updates the data structure for family events throughout the application. The changes involve restructuring the FamilieHendelse
type to distinguish between birth/pregnancy events and adoption events using optional properties.
- Replaces the existing
FamilieHendelseSamling
type with a simplifiedFamilieHendelse
type - Updates API endpoint from
familiehendelse-v2
tofamiliehendelse-v3
- Creates new specific types
FødselTerminFamilieHendelse
andAdopsjonFamilieHendelse
for better data structure
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
packages/types/src/familieHendelseTsType.ts | Completely refactors family event types to use optional properties for birth/adoption |
packages/types/index.ts | Exports the new family event types |
apps/fp-frontend-app/src/data/behandlingApi.ts | Updates API endpoint and return type for family events |
Multiple component files | Updates components to use the new simplified family event structure |
Multiple test and story files | Updates test data and stories to match new data structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/prosess/vilkar-soknadsfrist/src/components/ErSoknadsfristVilkaretOppfyltForm.tsx
Show resolved
Hide resolved
packages/fakta/adopsjon/src/components/DokumentasjonFaktaForm.tsx
Outdated
Show resolved
Hide resolved
f8c9eb2
to
7f16c6f
Compare
packages/fakta/omsorg-og-foreldreansvar/src/components/OmsorgsovertakelseFaktaPanel.tsx
Outdated
Show resolved
Hide resolved
7f16c6f
to
3a8d7eb
Compare
|
navikt/fp-sak#7538