Skip to content

Conversation

palfi
Copy link
Contributor

@palfi palfi commented Sep 5, 2025

@palfi palfi requested review from sirimykland and remhol September 5, 2025 11:33
@palfi palfi requested a review from a team as a code owner September 5, 2025 11:33
@palfi palfi force-pushed the feature/TFP-6071_v3 branch 2 times, most recently from 6fa1ab2 to 45d2ff6 Compare September 5, 2025 11:50
@palfi palfi requested a review from Copilot September 5, 2025 11:53
Copilot

This comment was marked as outdated.

@palfi palfi force-pushed the feature/TFP-6071_v3 branch from 45d2ff6 to 98f2936 Compare September 5, 2025 11:56
@palfi palfi requested a review from Copilot September 5, 2025 11:56
Copilot

This comment was marked as outdated.

Copy link
Contributor

@sirimykland sirimykland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan du se over propnavn der typen er endret. Jeg tenker spesielt på tilfeller av
gjeldendeFamiliehendelse: AdopsjonFamilieHendelse
familiehendelse: AdopsjonFamilieHendelse

@palfi palfi force-pushed the feature/TFP-6071_v3 branch from 98f2936 to 63f116f Compare September 5, 2025 12:01
@palfi palfi requested a review from Copilot September 5, 2025 12:02
Copilot

This comment was marked as outdated.

@palfi palfi force-pushed the feature/TFP-6071_v3 branch 2 times, most recently from 7bdf85c to bddbf5f Compare September 5, 2025 12:19
@palfi palfi requested a review from Copilot September 5, 2025 12:22
Copilot

This comment was marked as outdated.

@palfi palfi force-pushed the feature/TFP-6071_v3 branch from bddbf5f to 96d51d1 Compare September 5, 2025 12:29
@palfi palfi requested a review from Copilot September 5, 2025 12:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new API endpoint for family events and updates the data structure for family events throughout the application. The changes involve restructuring the FamilieHendelse type to distinguish between birth/pregnancy events and adoption events using optional properties.

  • Replaces the existing FamilieHendelseSamling type with a simplified FamilieHendelse type
  • Updates API endpoint from familiehendelse-v2 to familiehendelse-v3
  • Creates new specific types FødselTerminFamilieHendelse and AdopsjonFamilieHendelse for better data structure

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/types/src/familieHendelseTsType.ts Completely refactors family event types to use optional properties for birth/adoption
packages/types/index.ts Exports the new family event types
apps/fp-frontend-app/src/data/behandlingApi.ts Updates API endpoint and return type for family events
Multiple component files Updates components to use the new simplified family event structure
Multiple test and story files Updates test data and stories to match new data structure

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@palfi palfi force-pushed the feature/TFP-6071_v3 branch 2 times, most recently from f8c9eb2 to 7f16c6f Compare September 5, 2025 13:01
@palfi palfi requested a review from sirimykland September 8, 2025 06:24
@palfi palfi force-pushed the feature/TFP-6071_v3 branch from 7f16c6f to 3a8d7eb Compare September 8, 2025 07:29
Copy link

sonarqubecloud bot commented Sep 8, 2025

@palfi palfi merged commit a0bb8c4 into master Sep 8, 2025
7 checks passed
@palfi palfi deleted the feature/TFP-6071_v3 branch September 8, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants