Skip to content

Los app #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Los app #6543

wants to merge 5 commits into from

Conversation

tor-nav
Copy link
Collaborator

@tor-nav tor-nav commented Aug 12, 2025

No description provided.

@tor-nav tor-nav requested a review from a team as a code owner August 12, 2025 10:34
@tor-nav tor-nav marked this pull request as draft August 12, 2025 10:34
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 21, 2025
View reviewed changes
...sleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx
msw: {
handlers: [
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () =>

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '\u00f8'.

Copilot Autofix

AI 5 days ago

To fix the problem, we should ensure that all occurrences of 'ø' in the string are replaced with '%C3%B8'. The best way to do this in JavaScript is to use a regular expression with the global flag: .replace(/ø/g, '%C3%B8'). This will replace every occurrence of 'ø' in the string, not just the first. The change should be made on line 57 of apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx. No new imports or definitions are needed.

Suggested changeset 1
apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx b/apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx
--- a/apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx
+++ b/apps/fp-avdelingsleder/src/nokkeltall/fordelingAvBehandlingstype/FordelingAvBehandlingstypePanel.stories.tsx
@@ -54,7 +54,7 @@
     msw: {
       handlers: [
         http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
-        http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () =>
+        http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace(/ø/g, '%C3%B8'), () =>
           HttpResponse.json(OPPGAVER_FOR_AVDELING),
         ),
       ],
EOF
@@ -54,7 +54,7 @@
msw: {
handlers: [
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace('ø', '%C3%B8'), () =>
http.get(LosUrl.HENT_OPPGAVER_FOR_AVDELING.replace(/ø/g, '%C3%B8'), () =>
HttpResponse.json(OPPGAVER_FOR_AVDELING),
),
],
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
msw: {
handlers: [
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)),

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding High

This replaces only the first occurrence of '\u00f8'.

Copilot Autofix

AI 5 days ago

To fix the problem, we should ensure that all occurrences of 'ø' in LosUrl.HENT_OPPGAVER_PER_DATO are replaced with '%C3%B8'. The best way to do this in JavaScript is to use the replace method with a regular expression and the global flag: .replace(/ø/g, '%C3%B8'). This change should be made directly on line 65 of apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx. No new imports or dependencies are required, as this uses built-in JavaScript functionality.

Suggested changeset 1
apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx b/apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
--- a/apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
+++ b/apps/fp-avdelingsleder/src/nokkeltall/tilBehandling/TilBehandlingPanel.stories.tsx
@@ -62,7 +62,7 @@
     msw: {
       handlers: [
         http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
-        http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)),
+        http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace(/ø/g, '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)),
       ],
     },
   },
EOF
@@ -62,7 +62,7 @@
msw: {
handlers: [
http.get(LosUrl.KODEVERK_LOS, () => HttpResponse.json(alleKodeverkLos)),
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace('ø', '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)),
http.get(LosUrl.HENT_OPPGAVER_PER_DATO.replace(/ø/g, '%C3%B8'), () => HttpResponse.json(OPPGAVER_PER_DATO)),
],
},
},
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14 Security Hotspots
72.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tor-nav @mrsladek