-
Notifications
You must be signed in to change notification settings - Fork 27
1.8 (not for merge) #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jefferis
wants to merge
109
commits into
master
Choose a base branch
from
1.8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
1.8 (not for merge) #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unfortunately there seem to be some situations that cause digest differences but they are almost impossible to debug on CRAN * digest::sha1 does attempt to create a 32/64 bit stable hash, but even there are differences across package versions
* just contains bits and pieces for development
* UTF-8 for roxygen
* some of these spotted by R CMD check
* closes #402 * depending on filehash >=2.3 ensures that the bug this code was trying to kludge over is fixed at source.
* NB the pointsinside function will internally check if suggested Rvcg package is available
* see #411 * skipped on CRAN anyway but coming up elsewher now
* having trouble building Rvcg on trusty
* we weren't relying on the old behaviour beyond this test * closes #444
* See emails from BDR and Duncam Murdoch Re: CRAN packages requiring webshot2 but not declaring it * this is because rgl now prefers webshot2 (a non-CRAN package) for snapshots and offers no way to override this when using knitr rgl=T
* due to a change in base mappply docs
Warning: Topic 'fileformats': no parameters to inherit with @inheritParams * I suppose once upon a time registerformat was documented separately
* r-devel now refuses to compare a number with a numeric_version * reported by CRAN (Kurt Hornik, who also kindly pointed out the precise error)
* Simple Neurite Tracer is no more * The successor plugin, SNT, uses the same tracse format
* there are many functions deprecated in igraph v2.0.0 * unfortunately, I don't know what is the minimum igraph version for the new function names currently we only require igraph (>= 0.7.1) get.vertex.attribute->vertex_attr add.edges->add_edges decompose.graph->decompose graph.bfs->bfs graph.dfs->dfs is.connected->is_connected is.directed->is_directed get.vertex.attribute->vertex_attr shortest.paths->distances get.shortest.paths->shortest_paths induced.subgraph -> induced_subgraph no.clusters -> count_components clusters -> components minimum.spanning.tree -> mst delete.vertices -> delete_vertices set.vertex.attribute -> set_vertex_attr get.edgelist -> as_edgelist delete.edges -> delete_edges
* this still seems to be up in the air but at least some preparatory branches for igraph 2.0 use a 0 rather than NaN to signal unreachable nodes * see #517
* used to be an int, now numeric with igraph 2.0
* cmtk will never be installed there
* many conflicts after cherry picking from master to 1.8
* also remove unnecessary executable permissions
* workaround for new behaviour in R 4.5.1 associated with this change wch/r-source@7bc89c8
* we want to exclude swc.txt files since they are neither swc nor nml
* as.directed, as.undirected, graph * decided to wrap them so we don't have to fast forward igraph dependency to >=2.1.0 from >=1.0 * had to remove the explicit function imports (because we don't know which to import) * note that I also had to make an example conditional based on the installed version for the same reasons * see also igraph/rigraph#1513 * also fix some 1.8 conflicts when cherry-picking
* even private ones where the generic is not exported and will not be visible to outside users * some conflicts against 1.8 had to be resolved
* conflicts inc rda -> rds * had to remake rds I assume because format of summary output different in 1.8
* inc latest winbuilder result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.