[CHANGED] TLS: Changed SSL_verify_cb to natsSSLVerifyCb
#908
+35
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback uses a `void*` that the user should cast to a `X509_STORE_CTX*`. This removes the `nats.h` dependency on `NATS_HAS_TLS` and openssl headers. Programs that have a verification callback would have to modify it to change to a `void*` and do a cast, as described in the doc for the `natsSSLVerifyCb` verification callback. I have tested that an application compiled dynamically (with 3.10.1) and code that directly uses the `X509_STORE_CTX*` would work without problems if linked to a library build with this code. Signed-off-by: Ivan Kozlovic <[email protected]>
kozlovic
force-pushed
the
ssl_verify_cb
branch
from
3a27eda to
5e99d1f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 70.20% 70.18% -0.03%
==========================================
Files 48 48
Lines 17242 17243 +1
Branches 3540 3540
==========================================
- Hits 12105 12102 -3
- Misses 1734 1737 +3
- Partials 3403 3404 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback uses a
void*that the user should cast to aX509_STORE_CTX*.This removes the
nats.hdependency onNATS_HAS_TLSand openssl headers.Programs that have a verification callback would have to modify it to change to a
void*and do a cast, as described in the doc for thenatsSSLVerifyCbverification callback.I have tested that an application compiled dynamically (with 3.10.1) and code that directly uses the
X509_STORE_CTX*would work without problems if linked to a library build with this code.Signed-off-by: Ivan Kozlovic [email protected]