ADR-42 support failover on overflow policy as well as priority client policy #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
commented
Jul 11, 2025
ripienaar
changed the title
Jarema
requested changes
Jul 17, 2025
This adds the ability for overflow clients to take over the consumer when no unlimited clients are active. Without this ability the consumer could stall until the limits are reached and once reached again stall once the thresholds fall below the stated limits resulting in unconsumed messages. Essentially the current design works as long as all regions have actively consuming clients, this adds a feature that allows regions to create a cascading HA setup between them where for example us-east could take over for us-west after 5 seconds and eu-west would only step in after 10 seconds Signed-off-by: R.I.Pienaar <[email protected]>
ripienaar
force-pushed
the
overflow_failover
branch
from
7e3767b to
1bdc90a
Compare
|
Would this resolve nats-io/nats-server#5213? |
|
Thanks @MauriceVanVeen forgot that discussion. I think the concerns there about manual setup overhead and changing conditions still hold true. I think the new named policy approach for prio groups give us a better chance to iterate so we can start manual and later expand to more magical - also means we meet the customer need asap Gor sure good info in the linked issue |
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability for overflow clients to take over the consumer when no unlimited clients are active.
Without this ability the consumer could stall until the limits are reached and once reached again stall once the thresholds fall below the stated limits resulting in unconsumed messages.
Essentially the current design works as long as all regions have actively consuming clients, this adds a feature that allows regions to create a cascading HA setup between them where for example us-east could take over for us-west after 5 seconds and eu-west would only step in after 10 seconds