Solved: NBN_GameClient_Start does not support domain name #28 #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead. Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.
Contributor
Author
|
Interesting, that most tests succeed but 3 fail. I do not see how failing the emcc or webrtc soak tests is related to the code changed and could use some guidance on how to succesfully fix the issue. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NBN_GameClient_StartEx(...) we check if the host == "localhost" and use "127.0.0.1" instead. Also, updated the echo example to use host "localhost" to test this change. Everything seems to be working.