Skip to content

PR for review#10

Open
xargon666 wants to merge 59 commits into
reviewfrom
main
Open

PR for review#10
xargon666 wants to merge 59 commits into
reviewfrom
main

Conversation

@xargon666
Copy link
Copy Markdown
Collaborator

No description provided.

@tomhughes87
Copy link
Copy Markdown
Collaborator

+commit history
+organized files/ folders
+naming conventions
+repos' status
+readable
+no extra/ unused code
+readme (a bit light)
+yaml file fixed

-no server in client side = can't fetch from the api
-accidentally pushed node_modules to github before adding to gitignore
-empty styles.css file
-css not linked
-no labels in html = not accessible
-inconsistent code structure
-routes file empty
-empty docker-compose.yaml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants