refactor(expr-ir): Generalize __replace__, map_ir
#3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dangotbanned
commented
Sep 3, 2025
Comment on lines
+341
to
+343
| def map_ir(self, function: MapIR, /) -> Self: | ||
| """**WARNING**: don't use renaming ops here, or `self.name` is invalid.""" | ||
| return self.with_expr(function(self.expr.map_ir(function))) | ||
|
|
||
| def with_expr(self, expr: ExprIRT2, /) -> NamedIR[ExprIRT2]: | ||
| return cast("NamedIR[ExprIRT2]", replace(self, expr=expr)) | ||
| return replace(self, expr=function(self.expr.map_ir(function))) |
There was a problem hiding this comment.
Self isn't correct, but a current limitation of the type system
dangotbanned
changed the title
copy.replace most with_* methods __replace__, map_ir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
ExprIR(main) #3066ExprIR(main) #3066 (comment)copy.replacemostwith_*methods #3063Checklist
If you have comments or can explain your changes, please do so below