fix(research): warn when unsupported --sort or --page/--limit flags are passed#441
Closed
kome12 wants to merge 1 commit into
Closed
fix(research): warn when unsupported --sort or --page/--limit flags are passed#441kome12 wants to merge 1 commit into
kome12 wants to merge 1 commit into
Conversation
…re passed historical-token-flow-summary silently dropped --page/--limit; historical-smart-money-balances silently dropped --sort. Both now emit a warning to stderr so callers know their flag had no effect. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Closing — the fix approach was wrong. The correct fix is to reject the unsupported flags with a clear error rather than silently warning, since these flags have no effect at the API level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two `nansen research historical-*` subcommands silently ignored flags without any feedback to the caller:
Fix
Added `process.stderr.write()` warnings (matching the existing `⚠️ ` pattern used elsewhere in the codebase) that fire when the unsupported flag is detected:
Warnings go to stderr so they don't pollute JSON stdout output. The API call still succeeds — callers get data, plus a clear signal that the flag had no effect.
Tests
Added two regression tests in `src/tests/research.test.js`:
Both new tests pass alongside all 1475 existing tests (2 pre-existing skips unchanged).
Affected flag combinations
🤖 Generated with Claude Code