fix(schema): mark --to-date as required on historical-token-screener#440
Merged
Conversation
`requireOptions` incorrectly listed `to-date` as required, causing the command to reject valid calls that omit the optional `--to-date` flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The API requires `to_date` — the schema incorrectly marked it optional. Reverts the code/test changes from the prior commits and fixes the schema to match CLI and API behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
kome12
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug:
src/schema.jsonmarked--to-dateas optional onhistorical-token-screener, but both the CLI and the API require it. This mismatch could mislead AI agents and tooling that read the schema.Fix:
src/schema.jsonto add"required": trueonto-dateforhistorical-token-screenerrequireOptionsguard and help text changesVerified via CLI:
nansen research historical-token-screener --timeframe-days 30 --chains solana→ clear CLI error:Required: --to-datenansen research historical-token-screener --timeframe-days 30 --to-date 2026-05-18 --chains solana→ succeedsTest plan
npm testpasses (1473 passed, 2 skipped)npm run lintpasses--to-datewith a clear error--to-dateprovided🤖 Generated with Claude Code