feat: add solar wind GP #98
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
pinging @meyers-academic since he was looking at my previous PR |
| # get base Fourier design matrix and frequencies | ||
| f, df, fmat = fourierbasis(psr, components, T) | ||
|
|
||
| dt_DM = make_solardm(psr) |
Collaborator
There was a problem hiding this comment.
will this work? make_solardm returns a function but then is used as if it's a matrix. Same thing happens down below in makegp_timedomain_solar_dm. It's not clear to me where n_earth gets used here, for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.