fix: Use JAX Scipy and NumPy in discovery.matrix #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of places in
discovery.matrixusing hard coded NumPy and Scipy instead of the configured jnp and js, respectively. Some of these calls were in the outer functions of themake_*methods, so that's not a big deal. However, a number of the calls, especially in the*_varNclasses/methods, were calling hard coded NumPy and Scipy in inner methods. There were also a few places where*.linalg.*_solve()*.linalg.*_factor()were called instead of thematrix_solveandmatrix_factorglobals, so they were hard coded to use cholesky methods.I'm not sure if this was intentional, so this is a draft PR for now. @meyers-academic can you take a look at this and let me know what you think? I think you've looked at NumPy vs JAX in the
_varNmethods before?