Allow makecommongp_fourier to take different Tspans for different pulsars.
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fetch upstream
size). Add tests associated with it. Fix test in `test_likelihood.py`
meyers-academic
commented
Dec 20, 2024
|
|
||
| fs, dfs, fmats = zip(*[fourierbasis(psr, components, T) for psr in psrs]) | ||
| f, df = fs[0], dfs[0] | ||
| if isinstance(T, Iterable): |
Collaborator
Author
There was a problem hiding this comment.
I assume these if statements are ok because they will get evaluated once when compiled?
Collaborator
Author
There was a problem hiding this comment.
check that len(T) == len(psrs)
Collaborator
Author
|
@vallis same thing with this PR as well, I think this one should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
makecommongp_fourierto take different Tspans for different pulsars, and thus creating different bases for different pulsars. The basis for each pulsar must still be the same size.I have also added unit tests, making sure applying this to two pulsars, and running
Phi.getNgives equivalent results to runningPhi.getNonmakegp_fourierfor the two pulsars separately. There are a few more tests as well.