-
Notifications
You must be signed in to change notification settings - Fork 20
feat: Adding new models module #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AaronDJohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start to something that will be very useful. I recommend moving to the ArrayLikelihood which uses vmap across pulsars with the same noise models to be much faster on a GPU for these models which meet the requirements to use it. I've recommended code which should work. There are a couple of design options that we could pick:
- psr.noisedict vs noisedict
- common_type string vs correlation function
This is just a start. There's much that could be done here.
Example usage:
model_curn_vg = models.lhood_maker(psrs, wn_params, gamma_common=None, common_components=14, red_components=30, common_type='curn')