Skip to content

Conversation

@stevertaylor
Copy link
Collaborator

This is just a start. There's much that could be done here.

Example usage:
model_curn_vg = models.lhood_maker(psrs, wn_params, gamma_common=None, common_components=14, red_components=30, common_type='curn')

@stevertaylor stevertaylor changed the title Adding new models module feat: Adding new models module Aug 24, 2024
Copy link
Collaborator

@AaronDJohnson AaronDJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start to something that will be very useful. I recommend moving to the ArrayLikelihood which uses vmap across pulsars with the same noise models to be much faster on a GPU for these models which meet the requirements to use it. I've recommended code which should work. There are a couple of design options that we could pick:

  • psr.noisedict vs noisedict
  • common_type string vs correlation function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants