Skip to content

Conversation

@paulray
Copy link
Member

@paulray paulray commented Dec 29, 2025

Partially Fixes #1954

@dlakaplan
Copy link
Contributor

Do you want to add the numpy version check as part of this (so that it hopefully passes) and I can merge?

@paulray
Copy link
Member Author

paulray commented Dec 29, 2025

Sure, will do. Just a minute

@dlakaplan
Copy link
Contributor

I was looking at astropy and I'm not sure what their status is wrt numpy 2.4. I see a few issues/PRs like astropy/astropy#19096, but I don't see anything bigger. Nor do I see any limits on numpy versions in their requirements. So I don't know if we need a new astropy issue?

@dlakaplan
Copy link
Contributor

I was looking at astropy and I'm not sure what their status is wrt numpy 2.4. I see a few issues/PRs like astropy/astropy#19096, but I don't see anything bigger. Nor do I see any limits on numpy versions in their requirements. So I don't know if we need a new astropy issue?

Actually, that may be the issue I was having, so maybe there aren't larger problems. But did you file an issue with scipy?

@dlakaplan
Copy link
Contributor

(note that I do see issues like scipy/scipy#24212)

@paulray
Copy link
Member Author

paulray commented Dec 29, 2025

Oops, there are still unrelated changes here. Closing this PR and making a new one that is clean.

@paulray paulray closed this Dec 29, 2025
@paulray paulray deleted the ci-fx branch December 30, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numpy 2.4 causes some test failures

2 participants