Show logs in the correct Jupyter notebook cell #1952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1951. The problem where logging messages were shown in the incorrect cell (the cell where
pint.logging.setup()was called) seems to have been caused by passing theenqueue=Trueoption to Loguru'slogger.add()function. This PR simply removes the option. I've confirmed that this works both in a newer environment that showed the issue, and in an older one, which didn't have this issue, even withenqueue=True.I'm not sure why we were using
enqueue=Trueto begin with. The docstring forlogger.add()says this about it:Hopefully getting rid of this option (and switching back to
enqueue=False, which is the default in Loguru) will not cause issues in some use case I'm not aware of involving multiple PINT processes trying to log to a single file. But I think most likely this option was originally added in an attempt to get logging in a Jupyter notebook to work better, which is now backfiring.