Change StepProblem and MaxIterReached into warnings
#1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlakaplan
reviewed
Dec 18, 2025
src/pint/fitter.py
Outdated
| # If bad parameter values escape, look in ModelState.resids for the except | ||
| # that should catch them | ||
| lambda_ /= 2 | ||
| lambda_ /= 1.1 |
Contributor
There was a problem hiding this comment.
does this slow down the fit convergence?
Contributor
Author
There was a problem hiding this comment.
It does, in some cases. I have changed this to 1.5. I think 2 is too aggressive.
Contributor
|
OK, this looks fine to me. Should I merge? |
Contributor
Author
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downhill fitters too often emit
StepProblemandMaxIterReachedexceptions spuriously even when the fitting succeeds. This PR changes these into warnings so that the fitter doesn't fail. Not raising these as exceptions doesn't result in an invalid state since, in the worst-case scenario, the fitter remains in its initial state. This failure is communicated by the return value ofDownhillFitter.fit_toas().