Skip to content

Truncate the file before a StorageOperation write #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josesimoes merged 4 commits into from
Sep 7, 2026
Merged

Truncate the file before a StorageOperation write #3523

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f612a9b
Truncate the file before a StorageOperation write
Sep 6, 2026
517ef89
Report a failed delete instead of writing over the old content
Sep 6, 2026
86ea026
Shorten the comments around the pre-write delete
Sep 7, 2026
c59dc24
Code style fix
Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/HAL/nanoHAL_StorageOperation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ uint32_t HAL_StorageOperation(uint8_t operation, uint32_t dataLength, uint32_t o
char dirPath[FS_MAX_DIRECTORY_LENGTH];
char *lastSeparator;
int bytesWritten = 0;
HRESULT deleteResult;

// extract parent directory from relative path and create it if needed
snprintf(dirPath, sizeof(dirPath), "%s", relativePath);
Expand All @@ -74,6 +75,17 @@ uint32_t HAL_StorageOperation(uint8_t operation, uint32_t dataLength, uint32_t o
}
}

// Open() below doesn't truncate, so remove an existing file to start the write from an empty one
deleteResult = volume->Delete(relativePath, false);
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// a missing file, or a volume without Delete, is the normal case; any other failure would leave
// the previous content in place and the write would produce a file with a stale tail
if (FAILED(deleteResult) && deleteResult != CLR_E_FILE_NOT_FOUND && deleteResult != CLR_E_NOT_SUPPORTED)
{
errorCode = StorageOperationErrorCode::WriteError;
goto done;
}

// open the file (creates it, if it doesn't exist)
if (FAILED(volume->Open(relativePath, fileHandle)))
{
Expand Down
Loading