-
-
Notifications
You must be signed in to change notification settings - Fork 34
Bump IDF version and build counter #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdated azure-pipelines.yml to bump esp-idf repository tag from v5.2.3 to v5.4.2 and increment multiple job-specific REVISION counters from 1_12_4 to 1_14_0. No other steps, logic, or structure were changed. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
azure-pipelines.yml (1)
1262-1262
: IDF_PATH likely mismatches checkout path and is hardcoded
- Repo alias is esp32_idf and checkout uses “checkout: esp32_idf”. Default path becomes $(Build.SourcesDirectory)\esp32_idf, but IDF_PATH points to …\esp-idf. This can break builds when the template relies on IDF_PATH.
- Avoid hardcoding D:/a/1/s; use $(Build.SourcesDirectory) instead.
Apply this diff (option A: fix variable only):
- IDF_PATH: 'D:/a/1/s/esp-idf' + IDF_PATH: '$(Build.SourcesDirectory)\esp32_idf'Do this in both LilygoTWatch2020 and LilygoTWatch2021 jobs.
Alternative (option B: keep IDF_PATH as esp-idf, move checkout):
- checkout: esp32_idf + path: esp-idf
Then set:
- IDF_PATH: 'D:/a/1/s/esp-idf' + IDF_PATH: '$(Build.SourcesDirectory)\esp-idf'Also applies to: 1330-1330
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
azure-pipelines.yml
(23 hunks)
🔇 Additional comments (2)
azure-pipelines.yml (2)
47-47
: ESP-IDF bump to v5.4.2 — verify toolchain/template compatibilityPlease confirm templates and toolchain versions used by:
- download-install-esp32-build-components.yml@templatesBuild
- build-espressif-esp32-targets.yml@templatesBuild
match ESP-IDF v5.4.2 requirements (Python/CMake/Ninja/xtensa/ESP-IDF tools metadata). Update the templates if needed.
221-221
: Revision counters uniformly bumped to 1_14_0 — looks goodCounters are consistent across all targets.
Also applies to: 276-276, 331-331, 386-386, 441-441, 495-495, 550-550, 605-605, 660-660, 715-715, 770-770, 825-825, 880-880, 935-935, 988-988, 1043-1043, 1100-1100, 1155-1155, 1208-1208, 1269-1269, 1337-1337, 1399-1399
Description
Targets affected
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Summary by CodeRabbit