Skip to content

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Sep 17, 2025

Description

  • Update IDF version.
  • Bump version counter to 1.14.0.

Targets affected

  • BrainPad2
  • GHI_FEZ_CERB40_NF
  • GHI_FEZ_CERBERUS_NF
  • I2M_ELECTRON_NF
  • I2M_OXYGEN_NF
  • MBN_QUAIL
  • NESHTEC_NESHNODE_V1
  • NETDUINO3_WIFI
  • PybStick2x
  • ST_NUCLEO64_F401RE_NF
  • ST_NUCLEO64_F411RE_NF
  • ST_STM32F411_DISCOVERY
  • ST_NUCLEO144_F412ZG_NF
  • ST_NUCLEO144_F746ZG
  • ST_NUCLEO144_F767ZI
  • ST_STM32F4_DISCOVERY
  • ST_NUCLEO144_F439ZI
  • WEACT_F411CE
  • TI_CC1352P1_LAUNCHXL_868
  • TI_CC1352P1_LAUNCHXL_915
  • LilygoTWatch2020
  • LilygoTWatch2021
  • BUILD ALL

Motivation and Context

How Has This Been Tested?

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Summary by CodeRabbit

  • Chores
    • Upgraded ESP32 SDK to ESP-IDF v5.4.2, ensuring builds use the latest platform improvements.
    • Incremented firmware revision to 1.14.0 across supported boards/targets for the next release artifacts.
    • Build pipeline references updated accordingly; no changes to build steps or feature behavior.

Copy link

coderabbitai bot commented Sep 17, 2025

Caution

Review failed

The head commit changed during the review from 2059539 to 780293c.

Walkthrough

Updated azure-pipelines.yml to bump esp-idf repository tag from v5.2.3 to v5.4.2 and increment multiple job-specific REVISION counters from 1_12_4 to 1_14_0. No other steps, logic, or structure were changed.

Changes

Cohort / File(s) Change summary
Pipeline resource ref bump
azure-pipelines.yml
Updated resources.repositories.esp32_idf.ref from refs/tags/v5.2.3 to refs/tags/v5.4.2.
Revision counters across jobs
azure-pipelines.yml
Incremented REVISION variables from ..._1_12_4 to ..._1_14_0 for many targets (e.g., MBN_QUAIL, NESHTEC_NESHNODE_V1, BrainPad2, GHI_FEZ_* variants, I2M_* variants, WEACT_F411CE, ST_NUCLEO* variants, TI_CC1352P1_* (868/915), PybStick2x, LilygoTWatch2020/2021, NETDUINO3_WIFI). No other job definitions changed.

Sequence Diagram(s)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Bump IDF version and build counter" is concise and accurately captures the primary changes in the PR—updating the esp-idf tag and incrementing build/revision counters to 1.14.0 across CI jobs—matching the PR objectives. It clearly conveys the developer intent without unnecessary detail and is readable for teammates scanning history. The title is directly related to the changeset and not misleading.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
azure-pipelines.yml (1)

1262-1262: IDF_PATH likely mismatches checkout path and is hardcoded

  • Repo alias is esp32_idf and checkout uses “checkout: esp32_idf”. Default path becomes $(Build.SourcesDirectory)\esp32_idf, but IDF_PATH points to …\esp-idf. This can break builds when the template relies on IDF_PATH.
  • Avoid hardcoding D:/a/1/s; use $(Build.SourcesDirectory) instead.

Apply this diff (option A: fix variable only):

-    IDF_PATH: 'D:/a/1/s/esp-idf'
+    IDF_PATH: '$(Build.SourcesDirectory)\esp32_idf'

Do this in both LilygoTWatch2020 and LilygoTWatch2021 jobs.

Alternative (option B: keep IDF_PATH as esp-idf, move checkout):

   - checkout: esp32_idf
+    path: esp-idf

Then set:

-    IDF_PATH: 'D:/a/1/s/esp-idf'
+    IDF_PATH: '$(Build.SourcesDirectory)\esp-idf'

Also applies to: 1330-1330

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a12e64c and 7826698.

📒 Files selected for processing (1)
  • azure-pipelines.yml (23 hunks)
🔇 Additional comments (2)
azure-pipelines.yml (2)

47-47: ESP-IDF bump to v5.4.2 — verify toolchain/template compatibility

Please confirm templates and toolchain versions used by:

  • download-install-esp32-build-components.yml@templatesBuild
  • build-espressif-esp32-targets.yml@templatesBuild
    match ESP-IDF v5.4.2 requirements (Python/CMake/Ninja/xtensa/ESP-IDF tools metadata). Update the templates if needed.

221-221: Revision counters uniformly bumped to 1_14_0 — looks good

Counters are consistent across all targets.

Also applies to: 276-276, 331-331, 386-386, 441-441, 495-495, 550-550, 605-605, 660-660, 715-715, 770-770, 825-825, 880-880, 935-935, 988-988, 1043-1043, 1100-1100, 1155-1155, 1208-1208, 1269-1269, 1337-1337, 1399-1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants