Remove ninja install from azure-pipelines.yml #243
Conversation
Remove need for ninja (this is available in the CI image).
WalkthroughRemoved template references for Ninja and Arm GCC toolchain installers from many jobs in Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant P as Azure Pipeline
participant J as Build Job
U->>P: Trigger pipeline
P->>J: Start job
J->>J: Execute setup steps
alt Previously: installed Ninja & Arm GCC & ESP32 components (where applicable)
note right of J #DDEEFF: templates invoked for installers
J->>J: Download & install Ninja
J->>J: Download & install Arm GCC toolchain
J->>J: Download & install ESP32 build components
else Now: installer templates removed
note right of J #F7F7F7: installer template references removed
end
J->>J: Continue remaining steps (hexdfu, build targets, packaging, publish)
J-->>P: Job completes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
networkfusion
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
azure-pipelines.yml (2)
241-241: Consistent Removal of Ninja Installation Steps
All occurrences of the Ninja build installation template (i.e.
azure-pipelines-templates/download-install-ninja.yml@templatesBuild) have been commented out across multiple jobs. This change is consistent and aligns with the PR objective of eliminating the redundant download/install step since the CI image already includes Ninja.Please ensure that:
- The CI image indeed provides the correct version of Ninja so that downstream steps that might implicitly depend on it remain unaffected.
- If Ninja is no longer ever required in these pipelines, consider completely removing these lines (rather than leaving them commented) to reduce clutter and maintain clarity in the pipeline configuration.
Also applies to: 296-296, 351-351, 406-406, 460-460, 515-515, 570-570, 625-625, 680-680, 735-735, 790-790, 901-901, 955-955, 1010-1010, 1065-1065, 1120-1120, 1175-1175, 1235-1235, 1303-1303, 1366-1366
1387-1388: Duplicate Dependency in Report_Build_Failure Job
Within theReport_Build_Failurejob, the dependency list contains a duplicate entry forBuild_ST_NUCLEO64_F401RE_NF(lines 1387–1388). Removing this duplicate will improve clarity and prevent any potential confusion during dependency resolution.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
azure-pipelines.yml(21 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Community-Targets (Check_Code_Style)
- GitHub Check: Community-Targets (Check_Build_Options)
- GitHub Check: Community-Targets (Get_Commit_Message)
|
For another PR:
|
Description
Remove need for ninja (this is available in the CI image).
Targets affected
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
Summary by CodeRabbit