Skip to content

Conversation

@yito88
Copy link
Collaborator

@yito88 yito88 commented Oct 28, 2025

Describe your changes

Closes #4938.

Based on #4939

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2025

🧪 CI Insights

Here's what we observed from your CI run for 0d34825.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 test-e2e (2) Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

@brentstone
Copy link
Collaborator

@yito88 want to make sure - this closes #4938 right?

@yito88
Copy link
Collaborator Author

yito88 commented Oct 28, 2025

Yes, this closes #4938. Thanks for the update

@yito88 yito88 requested review from grarco and sug0 October 28, 2025 21:16
@sug0
Copy link
Collaborator

sug0 commented Oct 28, 2025

these two unit tests are now failing:

    vp::tests::test_timeout_on_close_packet
    vp::tests::test_timeout_packet

Copy link
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please add a changelog

@sug0 sug0 added bug Something isn't working IBC labels Oct 29, 2025
@sug0 sug0 added this to the Next Release milestone Oct 29, 2025
@brentstone
Copy link
Collaborator

Is this rdy for merge? @yito88 @tzemanovic @sug0

@sug0
Copy link
Collaborator

sug0 commented Nov 4, 2025

@brentstone it's ready, but I was waiting on #4939 to be approved+merged, since this PR is pretty simple, but it would introduce conflicts on #4939

@sug0 sug0 force-pushed the yuji/fix-refund-limit branch from 6aef5d2 to 0d34825 Compare November 17, 2025 16:18
@github-actions github-actions bot added the breaking:api public API breaking change label Nov 17, 2025
@sug0 sug0 mentioned this pull request Nov 19, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking:api public API breaking change bug Something isn't working IBC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IBC refunds trigger deposit per-epoch limits

5 participants