Add label to identify during cost distribution - #604
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, valid label addition to pod template metadata and does not alter selectors or workload behavior.
Pull request overview
This PR updates the Helm Deployment template to add a standard Kubernetes app label so the deployed pods can be more easily identified/grouped (e.g., for cost allocation/distribution tooling).
Changes:
- Adds the
app.kubernetes.io/instancelabel to the Deployment pod template labels, using the Helm release name as the value.
File summaries
| File | Description |
|---|---|
| charts/templates/deployment.yaml | Adds app.kubernetes.io/instance: {{ .Release.Name }} to pod labels for better identification/grouping. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.