Separate smiley parser into separate class.

[euantorano]

No description provided.

[euantorano]

So smiley parsing is now slightly better. I'm going to look at improving the Regular Expressions to ignore URLs and such, as I'm sure they're missing a few edge cases.

[wpillar]

Weird extra ; ?

[euantorano]

Oops.

[euantorano]

All sorted, ready for merge. Not sure why the test failed, unit tests run fine on my local machine and vagrant instance. Seems to be dependency issues, which can be resolved at a later date. I'd like to get this emerged sooner rather than later - been a bit slow on development recently.

[wpillar]

@euantorano it's because something is requiring PHPUnit 4.7 which requires PHP 5.6. Probably best to fix by adding a require-dev dependency for PHPUnit 4.6.* or similar in this repo (which there should be anyway ;) )

[euantorano]

Ah yes, that would be me requiring 4.7. It was building fine, but obviously the latest versions require PHP 5.6.

[JN-Jones]

Can you merge the latest commit and fix the issues?

[euantorano]

Sure.

On 25 Aug 2015, at 15:19, Jones [email protected] wrote:

Can you merge the latest commit and fix the issues?

—
Reply to this email directly or view it on GitHub.

[euantorano]

Ok, hopefully when Circle's done processing I'll be able to merge this.

[JN-Jones]

Ok, these are the errors I've noticed:

• CustomMyMyCodeRepository instead of CustomMyCodeRepository in MyBB\Parser\Database\Repositories\Eloquent\CustomMyCodeRepository
• CustomMyMyCodeCachingDecorator instead of CustomMyCodeCachingDecorator in ParserServiceProvider (wrong creation, wrong import and wrong class name in the class file itself)
• use Mybb in MyBB\Parser\Database\Repositories\SmileyRepository instead of use MyBB (throws an error on windows)

[euantorano]

Cheers, I'll fix them up tonight.

On 20 Oct 2015, at 12:05, Jones [email protected] wrote:

Ok, these are the errors I've noticed:

CustomMyMyCodeRepository instead of CustomMyCodeRepository in MyBB\Parser\Database\Repositories\Eloquent\CustomMyCodeRepository
CustomMyMyCodeCachingDecorator instead of CustomMyCodeCachingDecorator in ParserServiceProvider (wrong creation, wrong import and wrong class name in the class file itself)
use Mybb in MyBB\Parser\Database\Repositories\SmileyRepository instead of use MyBB (throws an error on windows)
—
Reply to this email directly or view it on GitHub.

[euantorano]

Yeah, need to work out why.

On 21 Oct 2015, at 01:07, Josh Harmon [email protected] wrote:

Issue with the CI runner: Problem 1

• Installation request for phpunit/php-code-coverage 3.0.x-dev -> satisfiable by phpunit/php-code-coverage[3.0.x-dev].
• phpunit/php-code-coverage 3.0.x-dev requires php >=5.6 -> your PHP version (5.5.21) or "config.platform.php" value does not satisfy that requirement.
  Problem 2
• Installation request for phpunit/php-code-coverage dev-master -> satisfiable by phpunit/php-code-coverage[dev-master].
• phpunit/php-code-coverage dev-master requires php >=5.6 -> your PHP version (5.5.21) or "config.platform.php" value does not satisfy that requirement.
  Problem 3
• Installation request for phpunit/phpunit 4.8.x-dev -> satisfiable by phpunit/phpunit[4.8.x-dev].
• phpunit/phpunit 4.8.x-dev requires phpunit/php-code-coverage ~2.1 -> no matching package found.
  Problem 4
• Installation request for phpunit/phpunit-mock-objects 3.0.x-dev -> satisfiable by phpunit/phpunit-mock-objects[3.0.x-dev].
• phpunit/phpunit-mock-objects 3.0.x-dev requires php >=5.6 -> your PHP version (5.5.21) or "config.platform.php" value does not satisfy that requirement.
  Problem 5
• Installation request for phpunit/phpunit-mock-objects dev-master -> satisfiable by phpunit/phpunit-mock-objects[dev-master].
• phpunit/phpunit-mock-objects dev-master requires php >=5.6 -> your PHP version (5.5.21) or "config.platform.php" value does not satisfy that requirement.

—
Reply to this email directly or view it on GitHub.

[JoshHarmon]

It's because the packages want 5.6, but the CI runner is configured to test with 5.5.21. We either have to pick specific package versions or upgrade the PHP version that we test with (which we don't really want to do).

[JN-Jones]

The issue was within phpunit and that we require the dev versions. They've fixed it on their side so a simple composer update fixed it (I've pushed the changes already to your branch :P). However there are a few issues with the code styling ;)

[JN-Jones]

@euantorano ;)