This repository was archived by the owner on Jun 22, 2018. It is now read-only.
Adding composer to docker-compose file #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows composer to be ran using `docker-compose run composer {command}`
Signed-off-by: Euan Torano <[email protected]>
Member
|
Thanks Euan, I'll be away from home for most of the holiday period and not able to test this easily until after the first week in January. I'll let you know as soon as I've had the chance! |
kawaii
reviewed
Jan 16, 2018
| restart: on-failure | ||
|
|
||
| composer: | ||
| image: composer |
Member
There was a problem hiding this comment.
Please pin this image to a specific version, i.e. composer:1.6.
kawaii
suggested changes
Jan 16, 2018
Member
kawaii
left a comment
kawaii
left a comment
There was a problem hiding this comment.
Composer image should be pinned to a specific version as per best practices for Docker.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows composer to be ran using
docker-compose run composer {command}- eg:docker-compose run composer update