fixing a few typos #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euantorano
requested changes
Jun 1, 2019
Member
euantorano
left a comment
euantorano
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor comments.
| We're proposing that we adopt the new [`symfony/mailer`](https://github.com/symfony/mailer) library which provides easy ways to send email via SMTP as well as various email APIs such as Postmark. | ||
| - [Review any missed templates fro the Twig conversion](https://github.com/mybb/mybb/issues/3684). During the re-base effort, we've noticed some lingering uses of the old template system within the core. These need to be rounded up and eliminated to ensure the template system usage throughout is consistent. | ||
| - [Update the ACP to allow editing of Twig template files](https://github.com/mybb/mybb/issues/3686). So far, the team have all been editing Twig template files directly via the Twig files. While this is a great way to work (who doesn't want to use their own editor of choice?), being able to eat templates easily within the ACP is a useful feature that needs updating to work with the new template system. There is some discussion about looking at the JavaScript code editor that we use when editing templates to see if there are any better options on the market. An often requested feature has been the ability to edit multiple templates within tabs at the same time, an enhancement which would be very handy when working with new templates. | ||
| - [Update the ACP to allow editing of Twig template files](https://github.com/mybb/mybb/issues/3686). So far, the team have all been editing Twig template files directly via the Twig files. While this is a great way to work (who doesn't want to use their own editor of choice?), being able to edit templates easily within the ACP is a useful feature that needs updating to work with the new template system. There is some discussion about looking at the JavaScript code editor that we use when editing templates to see if there are any better options on the market. An often requested feature has been the ability to edit multiple templates within tabs at the same time, an enhancement which would be very handy when working with new templates. |
Member
There was a problem hiding this comment.
Maybe I'm being dumb, but I can't see any difference here?
Member
There was a problem hiding this comment.
- to eat templates
+ to edit templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.