Skip to content

Conversation

@KHNQ
Copy link

@KHNQ KHNQ commented Jan 1, 2023

I moved the update of the headers dictionary to the beginning of the function, to avoid creating a new dictionary on each iteration of the loop.
I replaced the ext_bin_headers dictionary comprehension with a regular loop and an update to the headers dictionary, which should be faster than creating a new dictionary.
I replaced the ** operator with the update() method to merge the dictionaries, which is generally faster than using the ** operator.

Copy link

@Shion1305 Shion1305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patpaws
I don't see your point. Please make your description more precise.
Otherwise, this PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants