Repository navigation
Conversation
fix(core): sanitize reasoning parameter for openrouter
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where OpenRouter would reject requests for models that require reasoning (like
google/gemini-3.1-pro-preview) when thereasoningparameter was explicitly disabled.The Issue
When Claude Code sends a request with thinking disabled, the router translates this to
reasoning: { enabled: false }. However, OpenRouter's API does not support theenabledfield. Furthermore, for models that mandate reasoning, explicitly passing a disabled state causes a 400 Bad Request error.The Fix
This PR updates
OpenrouterTransformer.transformRequestInto properly sanitize thereasoningparameter:reasoning.enabledisfalse, thereasoningobject is deleted entirely. This allows OpenRouter to fall back to the model's default behavior.reasoning.enabledistrue, theenabledproperty is removed so that only theeffortparameter (which OpenRouter expects) is passed along.