Repository navigation
fix: correctly determine finish reason in gemini streaming - #1216
Open
PartTimeHackerman wants to merge 1 commit into
Open
PartTimeHackerman wants to merge 1 commit into
PartTimeHackerman wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where the finish reason was not being correctly determined in Gemini streaming mode, particularly when multiple response chunks were received.
Previously, the logic only considered the first candidate of the first response, which could lead to a null
finish_reasonif that initial chunk was not the final one.The updated implementation now correctly handles multiple response chunks by iterating through them to find the candidate that contains a
finishReason. This ensures that the final response is properly identified and thefinish_reasonis accurately reported.This change improves the reliability of response handling in streaming scenarios and prevents potential issues with incomplete or misidentified responses.