feat(carplay): wire Car Tabs setting to the browse-grid category list#610
Open
mvanhorn wants to merge 1 commit into
Open
feat(carplay): wire Car Tabs setting to the browse-grid category list#610mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
CarPlay's Browse grid was hardcoded to show all 7 categories regardless of the Settings → Car → Tabs preference. This adds `carBrowseCategories()` to KmpHelper (reads `SettingsRepository.carTabsConfig`, same source Android Auto uses) and threads it through CarPlayContentManager to pushBrowseGrid, which now builds the grid from the user-configured order/visibility instead of a fixed list. Item tap actions and bulk actions (Settings → Car → Item Actions) were already wired in a prior PR and remain unchanged. Fixes music-assistant#576
formatBCE
approved these changes
Jun 13, 2026
Collaborator
|
LGTM, but I'm not iOS dev. :) |
Contributor
|
Everything works great except that if a category is disabled (in Settings -> Car -> Tabs) it still shows up because disabled categories are removed before |
teancom
requested changes
Jun 13, 2026
| ?.takeIf { it in carTabCategories } | ||
| } | ||
| val present = parsed.toSet() | ||
| val missing = carTabCategories.filter { it !in present } |
Contributor
There was a problem hiding this comment.
Probably around here to track all valid stored categories as present, while only returning enabled ones
Collaborator
There was a problem hiding this comment.
@mvanhorn will you address comments, or should we close this and start from scratch?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CarPlay now honors the Car Settings tab/action preferences configured in Settings → Car.
SettingsRepository.carTabsConfig(the same store Android Auto uses) via a newcarBrowseCategories()bridge method inKmpHelper. Categories are shown in the user-configured order; disabled categories are hidden; unconfigured categories appear in the default order.KmpHelper.playCarDefaultTap. No change needed.KmpHelper.carBulkActionNames/playCarAction. No change needed.Note: a full iOS/CarPlay build requires Xcode and the KMP toolchain; CI is the verification gate for compilation.
Why this matters
Issue #576 reported that changing the Car Settings tabs and item action preferences had no effect on the CarPlay UI. The settings were persisted but the CarPlay layer did not read them. Maintainer
seadowgconfirmed 2025-06-11 the issue is purely about the settings not affecting the CarPlay UI.Fixes #576