Skip to content

Remove the mnxdom and mnx_w3c recipes - #38

Open
rpatters1 wants to merge 1 commit into
musescore:mainfrom
rpatters1:remove-mnxdom-recipes
Open

rpatters1 wants to merge 1 commit into
musescore:mainfrom
rpatters1:remove-mnxdom-recipes

Conversation

@rpatters1

@rpatters1 rpatters1 commented Aug 6, 2026

Copy link
Copy Markdown

Neither of the mnxdom nor mnx_w3c recipes has a consumer. MuseScore is the only app that uses mnxdom, and
musescore/MuseScore#34487 has it take just nlohmann_json and json_schema_validator from muse_deps while fetching mnxdom itself in-module.

As I understand current thinking, mnxdom is not going to move into muse_deps until MNX has an official spec. This could be many months away. The schema is still revising and mnxdom moves with it. Behind muse_deps each revision means a recipe bump, a prebuilt/lock cycle, and a submodule pin bump, for a dependency a single MuseScore module uses.

mnx_w3c existed only to feed MNX_W3C_SOURCE to the mnxdom recipe. mnxdom now vendors the W3C schema and examples under third_party/w3c-mnx (mnx-works/mnxdom#56, #58), so nothing points at it.

Both recipes are also stale. recipes/mnxdom pins e7c947b (2026-02-21, DEP_VERSION 2.1), from before MNX schema 27; MuseScore needs 45bf462 (v3.1.0). Its 0001-link-namespaced-json-schema-validator.patch was obsoleted upstream by mnx-works/mnxdom#57, which selects the bare or namespaced validator target on its own — the patch no longer applies to any current mnxdom. Adopting these recipes later would mean rewriting them, not reusing them, so this is a revert-friendly deletion rather than a loss.

Scope and checks:

  • Both were DEP_KIND source, so there are no prebuilt.lock entries and no published archives to retire.
  • No other reference to either name exists in muse_deps, MuseScore, or muse_framework.
  • Recipes are discovered by glob, so nothing enumerated them by name.
  • cmake -P buildtools/validate.cmakeOK - 54 deps (52 buildable), recipes + prebuilt.lock well-formed.
  • recipes/nlohmann_json and recipes/json_schema_validator stay; MuseScore now requires both directly.
  • This PR can be merged independently of MNX: get mnxdom's json dependencies from muse_deps  MuseScore#34487.

MuseScore is the only consumer of either recipe, and it no longer
resolves mnxdom through muse_deps: src/importexport/mnx fetches mnxdom
itself and takes only nlohmann_json and json_schema_validator from here.

mnx_w3c existed solely to feed MNX_W3C_SOURCE to the mnxdom recipe.
mnxdom now vendors the w3c schema and examples under third_party/w3c-mnx,
so there is nothing left to point it at.

Both recipes are stale on top of that: mnxdom pins a pre-schema-27
commit, and its patch was obsoleted upstream by mnx-works/mnxdom#57,
which picks the bare or namespaced validator target on its own.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant