Fix crash when pressing key while dynamics handle selected #30236
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: musescore#30229 TextBase methods love `static_cast<TextEditData*>(ed.getData(this).get())`, but that’s a bit of a problem when it’s actually only `ElementEditData`, as is the case when a dynamic is in grip edit mode.
cbjeukendrup
force-pushed
the
dynamics_crash_edit
branch
from
50aa94b to
7b99f34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #30229
TextBase methods love
static_cast<TextEditData*>(ed.getData(this).get()), but that’s a bit of a problem when it’s actually onlyElementEditData, as is the case when a dynamic is in grip edit mode.