-
Notifications
You must be signed in to change notification settings - Fork 7
Overhaul PyDesigner Code 2 #312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… feature/project-overhaul-2
…ridge/PyDesigner into feature/project-overhaul-2
|
@ryn-thorn @gonzoBlackMamba This update is ready. Please test on your end and let me know if it works fine. You need to have Poetry installed and need AT LEAST Python 3.12. Switch to this branch and run |
|
@TheJaeger this is great! I got it to run on a test data set. Two things immediately come to my attention:
However, the fbi_odf_mrtrix.nii file is flipped in the axial and coronal directions (see images) |
|
@TheJaeger I was also under the impression that we needed everything in RAS, however the dwi_raw and dwi_preprocessed images are LPS: |
|
@TheJaeger: as are the output metric image maps (for instance the FAA) |
|
@TheJaeger for the fbi_odf_mrtrix.nii file, not certain, but you may need to flip the gradient directions in the x- and y-directions (the ones that make up the azimuthal angle ('phi') to match the RAS orientation of MRtrix... |
|
@TheJaeger last thing for now: I see that on the command line process the GFA and peak detection register 0% while everything else completes normally |





This PR fixes various reported bugs and updates documentation to tackle:
In addition, PyDesigner will undergo transition to Poetry for package management and pre-commit for hooks and tests. Automations will also be introduced to automatically publish, release, and document changes.
Another big change is to transition PyDesigner into a diffusion imaging library i.e. various functions of PyDesigner can be called for custom scripting.
Closes #303 #305 #306 #308