Skip to content

Add Environmental Value and Advertise LB IP if specified #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Environmental Value and Advertise LB IP if specified #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0587b7
Add Environmental Value and Advertise LB IP if specified
angryninja48 Jan 8, 2019
155eb9e
Update deployment.yaml
angryninja48 Jan 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions charts/kube-plex/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,13 @@ spec:
value: "{{ .Values.persistence.config.claimName }}"
{{- else }}
value: "{{ template "fullname" . }}-config"
{{- end }}
{{- if and (.Values.service.loadBalancerIP) (eq .Values.service.type "LoadBalancer") }}
- name: ADVERTISE_IP
value: "http://{{ .Values.service.loadBalancerIP }}:32400"
Copy link
Owner

@munnerz munnerz Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to make it possible to use TLS, this var needs to be set to a hostname instead of an IP.

It may be better if we simply expose setting ADVERTISE_IP to some arbitrary value via the values.yaml file instead of requiring using the services IP address.

Copy link
Author

@angryninja48 angryninja48 Jan 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same thought - The user could just pass it in via the env value if they wanted to override it

{{- end }}
{{ if .Values.env }}
{{ toYaml .Values.env | indent 8 }}
{{- end }}
volumeMounts:
- name: data
Expand Down
6 changes: 6 additions & 0 deletions charts/kube-plex/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,9 @@ resources: {}
# requests:
# cpu: 100m
# memory: 128Mi
env:
# Optional
## Specify additional environmental variables for kube-plex and/or plex
## docker images
# - name: ADVERTISE_IP
# value: "http://1.1.1.1:32400/"