[code-infra] Upload the nightly React runs as Argos subset builds - #49123
Open
LukasTy wants to merge 2 commits into
Open
[code-infra] Upload the nightly React runs as Argos subset builds#49123LukasTy wants to merge 2 commits into
LukasTy wants to merge 2 commits into
Conversation
The react@17/18/next regression jobs upload to Argos with the same build name as the normal run. Master approves every build, so a nightly run can become the baseline that PRs compare against. Name these builds after their CircleCI job. Argos compares only builds with the same name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LukasTy
added
test
scope: code-infra
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
Replace the separate build name with a subset build. Argos never uses a subset build as a baseline, and it ignores the screenshots that these runs skip. With the default build name, these runs compare with the stable run on the same commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LukasTy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
test_regressions-react@18andtest_regressions-react@nextjobs upload to Argos like the normaltest_regressionsrun. Master auto-approves every build, and Argos uses the last approved build on the merge-base commit as the baseline. So a nightly run can become the baseline that PRs compare against.For example, the nightly React 18 build was the last build on
5ce5a0f(https://app.argos-ci.com/mui/material-ui/builds/52007). The React 18 run skipsCrudDashboardsince #49027, so #49122 showedCrudDashboard.pngas added (https://app.argos-ci.com/mui/material-ui/builds/52015/456363749).This PR uploads the non-stable React runs (react@17, react@18, react@next) as subset builds. Argos never uses a subset build as a baseline, and it ignores the screenshots that a subset build does not have (https://argos-ci.com/docs/learn/how-to-guides/ci-pipelines/subset-builds).
@argos-ci/corereadsARGOS_SUBSETfrom the environment, so code-infra needs no change for this. With the default build name, Argos compares these runs with a stable master run.These builds still run on master, so Argos still auto-approves them, and a React-specific difference does not fail. The next step is to set
ARGOS_BRANCHto another branch, so that Argos does not auto-approve them. They also needARGOS_REFERENCE_COMMIT=$CIRCLE_SHA1, so that the baseline stays the stable run on the same commit.ARGOS_BRANCHneeds mui/mui-public#1853 in code-infra.The
test_regressionsjob on this PR uses the stable React version, so it skips the new step.