-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Bump yargs to ^18.0.0 #46578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump yargs to ^18.0.0 #46578
Conversation
e02dad9
to
ce96e26
Compare
Netlify deploy previewhttps://deploy-preview-46578--material-ui.netlify.app/ Bundle size report
|
ce96e26
to
317eb7f
Compare
317eb7f
to
a6be826
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
On mui-x
this major has been used for quite a while.
However, I've checked that we didn't account for this being a direct dependency on the codemod
package.
The minimum supported Node
version is 20.19, whereas we declare support for >14.00 om the package. 🙈
So, technically, @mui/x-codemod
is already lying about this...
material-ui/packages/mui-codemod/package.json
Lines 51 to 53 in cf0940b
"engines": { | |
"node": ">=14.0.0" | |
} |
WDYT @Janpot, should we avoid bumping this and potentially even downgrade the
yargs
package on mui-x
? 🤔
@Janpot Can you take a look? |
👍 I'm ok with bumping the engines field to match |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I'm ok with bumping the engines field to match
yargs
.
Ain't it a breaking change? 🤔
AFAIK, Olivier was adamant about keeping the engines.node
as lenient as possible, but this is just about the codemod
package. 🤷♂️
@@ -36,7 +36,7 @@ | |||
"jscodeshift-add-imports": "^1.0.11", | |||
"postcss": "^8.5.6", | |||
"postcss-cli": "^11.0.1", | |||
"yargs": "^17.7.2" | |||
"yargs": "^18.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are fine with this slight BC, then this package engines.node
field needs to be updated to >=20.19
.
Not if it's already broken in practice. When did we upgrade to the
Personally, I don't see why we even put a restriction at all on our components packages. On our CLI tools I think it is desired to only support maintained versions of node.js. Even the most trivial dependency trees would have at least one dependency that restricts it to this version anyway. Note that technically, for packages like that we should also configure the corresponding |
This PR contains the following updates:
^17.7.2
->^18.0.0
Release Notes
yargs/yargs (yargs)
v18.0.0
Compare Source
⚠ BREAKING CHANGES
command
.^20.19.0 || ^22.12.0 || >=23
.Features
Bug Fixes
Code Refactoring
command
. (d90af45)Build System
^20.19.0 || ^22.12.0 || >=23
. (d90af45)Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.