Fixes here and there #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Middleware has changed in django 1.10, see https://docs.djangoproject.com/en/1.10/topics/http/middleware/#upgrading-pre-django-1-10-style-middleware This mixin is just "band aid"
It happens that if USERNAME_FIELD is not 'username' like it usually isn't for custom user models, then self.username is None, leading to empty fields for username.
Getting the "username" should be done with get_username() otherwise an AttributeError is raised on custom user models with custom USERNAME_FIELD
Note to add useraudit to project urls file
Django complains when a naive datetime is saved into a DateTime model field. Fix to issue #1
sztamas
suggested changes
Jan 9, 2017
useraudit/backend.py
Outdated
| def authenticate(self, **credentials): | ||
| UserModel = get_user_model() | ||
| self.username = credentials.get(get_user_model().USERNAME_FIELD) | ||
| self.username = credentials.get('username') |
Contributor
There was a problem hiding this comment.
Why is this needed?
The current version seems more flexible to me.
Author
There was a problem hiding this comment.
in retrospect, I can seem to remember why.
useraudit/middleware.py
Outdated
| @@ -1,11 +1,12 @@ | |||
| import threading | |||
| from django.utils.deprecation import MiddlewareMixin | |||
Contributor
There was a problem hiding this comment.
This will fail on pre 1.10 Django.
you should do something along these lines:
useraudit/models.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| from django.db import models | |||
| from django.utils import datetime | |||
Contributor
There was a problem hiding this comment.
I like the change but shouldn't this be?
from django.utils import timezone
import from django.utils should have been timezone, not datetime
Make 1.10 compatible without breaking pre 1.10
reverted to get the USERNAME_FIELD off get_user_model()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes are without automated tests. Although I don't think anything is 1.10 specific, but I made these fixes against 1.10...since most will probably still be running 1.9.
Most of this came to the fore because I'm using a custom user model.