add an option to send only matches to receiving services #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this greatly reduces the size of delta messages in stacks with large data changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of services only care about certain triples, having this filtering logic in one place seems logical to me.
This greatly reduces the size of delta messages in stacks with large data changes, limiting the amount of json serialization that needs to be done at both ends.
NOTE: this currently only adapts insert and delete on a changeSet, but not the effectiveInsert and effectiveDelete. If this feature is deemed useful I can quite easily extend the logic to also filter those.
EDIT: I set up a build, you can test this using
nvdk/mu-delta-notifier:feature-filter-changesets