Make gameboard use edn instead of json#7564
Open
NoahTheDuke wants to merge 2 commits intomtgred:masterfrom
Open
Make gameboard use edn instead of json#7564NoahTheDuke wants to merge 2 commits intomtgred:masterfrom
NoahTheDuke wants to merge 2 commits intomtgred:masterfrom
Conversation
This was referenced Jul 17, 2024
NoahTheDuke
force-pushed
the
nb/edn-cljs
branch
2 times, most recently
from
54de01e to
d031517
Compare
Collaborator
Author
|
I should have merged this lol. I'll update and merge this week |
Collaborator
|
hmm, maybe we can try to merge this after the elevation release? |
Collaborator
Author
|
Yeah I gotta dust this off and bite the bullet. I mostly didn't do it because I don't have control over deployments so didn't want to do something I can't undo fast/give jdeng a bunch of extra work, but I think it'll be worthwhile in the long run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of my fears about ruining history is incorrect, as we're already storing the history as json in the database. If replays are broken, we can fix them. Otherwise, I think we should pull the trigger.