Skip to content

Conversation

mmuetzel
Copy link
Collaborator

@mmuetzel mmuetzel commented Jun 6, 2025

Probably fixes #24493.

@mmuetzel mmuetzel mentioned this pull request Jun 6, 2025
6 tasks
@mmuetzel
Copy link
Collaborator Author

mmuetzel commented Jun 6, 2025

Apparently, this change leads to a lot of symbols that are no longer being exported from the shared libraries. But the missing symbols from #24493 are exported from libicuin77.dll now.

I checked a few of the symbol names that are no longer exported. And afaict, they corresponded to internal functions (that aren't defined in the installed headers and don't have API attributes in the sources).
Also, the package grokker didn't detect any packages that are using those symbols.

@lazka
Copy link
Member

lazka commented Jun 6, 2025

lgtm

In theory icu-uc.pc could be extended with Cflags.private: -DU_STATIC_IMPLEMENTATION so the dllimport is removed for "pkgconf --static" again. Not sure how likely that is that users depended on that.

@mmuetzel
Copy link
Collaborator Author

mmuetzel commented Jun 8, 2025

Good point!

I amended the patch to also add that line to the pkg-config files.

@lazka lazka merged commit c5fcf93 into msys2:master Jun 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QT6 cannot build icu by cmake.
2 participants