update to ngspice 45.2 #23283
update to ngspice 45.2 #23283
Conversation
|
hmm it seems on CI it compiles fine |
mingw-w64-ngspice/PKGBUILD
Outdated
| "${_common_flags[@]}" \ | ||
| --with-ngshared | ||
| make | ||
| make -j |
There was a problem hiding this comment.
when testing it, it didn't seem it was getting passed, or maybe it was a placebo effect, but I thought -j made things faster.
There was a problem hiding this comment.
I've tested it on my laptop, and I'm pretty sure the makefiles that ngspice seems configuring "-j" is not passed automatically, i mean unless makefile also listen to an env var im Not aware of? This is outside the PKGBUILD
| [LIBS="$LIBS -lreadline"], | ||
| [AC_MSG_ERROR([Couldn't find readline libraries.])]) | ||
| + | ||
| +PKG_CHECK_MODULES_STATIC([NCURSES], [ncursesw], [ |
There was a problem hiding this comment.
why is curses needed? It's not linking against it.
There was a problem hiding this comment.
only statically, it does get used.
https://github.com/imr/ngspice/blob/e011d14f6fd9595723b2acd6e21324826f25aef5/src/frontend/terminal.c#L26
because if you link dynamically we get another error, namely:
#10312
There was a problem hiding this comment.
ahhh you mean curses should not be runtime dependency, yeah,I think you're right, sorry about that.
| cd $(DESTDIR)$(pkglibdir); \ | ||
| rm -f ivlng*a libvvp* ; \ | ||
| - mv ivlngvpi.* ivlng.vpi | ||
| + if [ -f ivlngvpi.* ]; then \ |
There was a problem hiding this comment.
We compile 3 times, correct, when doing the nonshared version (ngspice_con), ivlngvpi doesn't get generated, probably libtool shenanigans,
https://sourceforge.net/p/ngspice/bugs/735/
|
I notice that after simply updating the branch suddenly it cannot be built with clang, while obviously, it in the past could, is this a clang bug? or a ngspice regression or more likely clang doesnt accept this anymore? |
Enabling osdi, allows for ngspice to simulate pdks like the IHP130pdk, https://github.com/IHP-GmbH/IHP-Open-PDK
* test * ngspice 45.2
|
@lazka managed to make it buildable with 45.2 and clang again.. |
* update to ngspice 44.2 * curses not runtime dependent * ngspice: enable osdi Enabling osdi, allows for ngspice to simulate pdks like the IHP130pdk, https://github.com/IHP-GmbH/IHP-Open-PDK * Update ngspice version to 45.2 in PKGBUILD * Ngspice2osdi (#10) * test * ngspice 45.2 * Fix LDFLAGS syntax for clang in PKGBUILD * Remove illegal specialization for compilation * Update sha256sum for a package in PKGBUILD
I would like assistance updating ngspice to 44.2 as you can see the .dll is missing, there are some libtool warnings, not sure what I did wrong :)