Allow building without serialization / json support #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @jcelerier, thanks for your PR. On which embedded system do you want to use TinySpline? I'll have a look at your PR. So far, it looks well done, thanks. |
msteinbeck
reviewed
Jul 13, 2023
src/CMakeLists.txt
Outdated
| if(NOT TINYSPLINE_SERIALIZATION) | ||
| list(APPEND TINYSPLINE_C_DEFINITIONS "TINYSPLINE_NO_SERIALIZATION") | ||
| list(APPEND TINYSPLINE_CXX_DEFINITIONS "TINYSPLINE_NO_SERIALIZATION") | ||
| list(APPEND TINYSPLINE_BINDING_CXX_DEFINITIONS "TINYSPLINE_NO_SERIALIZATION") |
Owner
There was a problem hiding this comment.
We will probably never build one or more bindings without serialization support.
msteinbeck
reviewed
Jul 13, 2023
| #include "tinyspline.h" | ||
|
|
||
| #if !defined(TINYSPLINE_NO_SERIALIZATION) | ||
| #include "parson.h" /* serialization */ |
Owner
There was a problem hiding this comment.
#include <stdio.h> can also be excluded as we only use FILE and fopen from it. I propose to move this line into the !defined(TINYSPLINE_NO_SERIALIZATION) block.
Contributor
Author
|
hi, thanks for your quick answers! I'm targetting ESP8266, ESP32 and raspberry pi pico (RP2040) so far |
Owner
|
Very interesting. Isn't the dynamic allocation of memory a problem on these platforms? |
msteinbeck
reviewed
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some very small embedded builds :)